Update pull-requests.md #2960
Merged
Update pull-requests.md #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update developer docs to make it clearer how many approvals are required
jeddy3
requested changes
Oct 13, 2017
| - Sentence case. | ||
| - Descriptive. | ||
| 2. Update the [CHANGELOG](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) directly via the [GitHub website](https://github.com/stylelint/stylelint/edit/master/CHANGELOG.md) for all merged PRs (except documentation changes). | ||
| 3. Update the [CHANGELOG](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) directly via the [GitHub website](https://github.com/stylelint/stylelint/edit/master/CHANGELOG.md) for all merged PRs (except documentation changes). |
There was a problem hiding this comment.
Please swap the period for colon at the end of this, for consistency.
- Update the CHANGELOG directly via the GitHub website for all merged PRs (except documentation changes):
pr feedback
hudochenkov
reviewed
Oct 13, 2017
| 1. "Squash and merge" commits, ensuring the resulting commit message is consistently formatted: | ||
| 1. Make sure the pull request has the correct number of approvals: | ||
| - For simple documentation fixes: one | ||
| - For all other pull requests: two |
There was a problem hiding this comment.
I think punctuation marks are missing. I'm not sure, but maybe the following ones are correct:
- For simple documentation fixes: one;
- For all other pull requests: two.
pr feedback
alexander-akait
approved these changes
Oct 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update developer docs to make it clearer how many approvals are required
None, as it's a documentation fix.
No, it's self explanatory.