New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postcss-sass as dependency, because postcss-html needs it #3040

Merged
merged 1 commit into from Nov 28, 2017

Conversation

4 participants
@hudochenkov
Member

hudochenkov commented Nov 27, 2017

Which issue, if any, is this issue related to?

#3035

Is there anything in the PR that needs further explanation?

We don't use postcss-sass in our codebase, but it's a peer dependency of postcss-html, which we use. Luckily postcss-html doesn't fail if not every its dependency installed. But it might change theoretically, and we'll have a problem. Also we don't want annoy people by unmeet dependency messages.

@jeddy3

jeddy3 approved these changes Nov 27, 2017

@hudochenkov hudochenkov merged commit abe53c0 into master Nov 28, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.673%
Details

@hudochenkov hudochenkov deleted the issue-3035 branch Nov 28, 2017

@GreenGremlin

This comment has been minimized.

GreenGremlin commented Dec 12, 2017

Will this change be published soon? The peerDependency warnings are getting a bit annoying.

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Dec 12, 2017

@stylelint/core If no one beats me to it, I can do a minor release this evening.

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Dec 15, 2017

@GreenGremlin A regression delayed the release, but 8.4 is out now and should remove the peerDependency warning.

@GreenGremlin

This comment has been minimized.

GreenGremlin commented Dec 15, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment