Add postcss-sass as dependency, because postcss-html needs it #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
approved these changes
Nov 27, 2017
CAYdenberg
approved these changes
Nov 28, 2017
|
Will this change be published soon? The peerDependency warnings are getting a bit annoying. |
|
@stylelint/core If no one beats me to it, I can do a minor release this evening. |
|
@GreenGremlin A regression delayed the release, but |
|
Thanks! |
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3035
We don't use
postcss-sassin our codebase, but it's a peer dependency ofpostcss-html, which we use. Luckilypostcss-htmldoesn't fail if not every its dependency installed. But it might change theoretically, and we'll have a problem. Also we don't want annoy people by unmeet dependency messages.