New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to block-opening-brace-newline-after #3441

Merged
merged 9 commits into from Aug 13, 2018

Conversation

3 participants
@ota-meshi
Member

ota-meshi commented Jul 4, 2018

Which issue, if any, is this issue related to?

e.g. "Closes #000" or "None, as it's a documentation fix."

block-opening-brace-newline-after in #2829

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

ex.

  • option: always***

    code:

    a { color: pink; }

    fixed:

    a {
     color: pink; }
  • option: never-multi-line

    code:

    a {
    color: pink;
    background: orange; }

    fixed:

    a {color: pink;
    background: orange; }

In order to solve the problem of indentation due to newline insertion, the indentation processing was modified to be done at the last.

ota-meshi added some commits Jul 4, 2018

Fixed of the following
* Fixed the behavior of `never-multi-line` when there are multiple comments.
* Fixed to insert a newline at the after comment when comment exists.
    #3421 (comment)

@jeddy3 jeddy3 changed the title from Add autofix to `block-opening-brace-newline-after` to Add autofix to block-opening-brace-newline-after Jul 21, 2018

@hudochenkov

Autofixing looks good.

I'm not sure what problem with indentation you're talking about. Anyway, it's better to do it in another PR. Could you remove indentation related changes from this PR and send them as another PR, please? Include before/after, so we could see what the problem is. Add tests for this problem.

@ota-meshi

This comment has been minimized.

Member

ota-meshi commented Aug 11, 2018

@hudochenkov Thank you for checking!
I reverted the change of indentation. so please check again.

@hudochenkov

👍

@modosc modosc referenced this pull request Aug 12, 2018

Closed

Add autofix to rules for parity with stylefmt #2829

19 of 21 tasks complete
@jeddy3

jeddy3 approved these changes Aug 12, 2018

LGTM

@jeddy3 jeddy3 merged commit 287da28 into stylelint:master Aug 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.117%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Aug 13, 2018

  • Added: block-opening-brace-newline-after autofix (#3441).

@ota-meshi ota-meshi deleted the ota-meshi:dev/fixable--block-opening-brace-newline-after branch Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment