New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to declaration-colon-space-before #3445

Merged
merged 4 commits into from Jul 15, 2018

Conversation

4 participants
@ota-meshi
Member

ota-meshi commented Jul 7, 2018

Which issue, if any, is this issue related to?

declaration-colon-space-before in #2829

Is there anything in the PR that needs further explanation?

ex.

  • option: always

    code:

    a { color: pink; }

    fixed:

    a { color : pink; }
  • option: never

    code:

    a { color : pink; }

    fixed:

    a { color: pink; }

@ota-meshi ota-meshi force-pushed the ota-meshi:dev/fixable-declaration-colon-space-before branch from 60bbe49 to c0c051d Jul 7, 2018

fix: context.fix
? decl => {
if (expectation === "always") {
decl.raws.between = decl.raws.between.replace(/^\s*:/, " :");

This comment has been minimized.

@evilebottnawi

evilebottnawi Jul 9, 2018

Member

What about if i have comment display/*comment*/:/*comment*/block;? Please add test

@ota-meshi

This comment has been minimized.

Member

ota-meshi commented Jul 9, 2018

@evilebottnawi Thank you for review!
I changed it, so please check it.

@jeddy3 jeddy3 changed the title from Add autofix to `declaration-colon-space-before` to Add autofix to declaration-colon-space-before Jul 10, 2018

@jeddy3

jeddy3 approved these changes Jul 10, 2018

@ota-meshi Thanks, LGTM!

@ntwb

ntwb approved these changes Jul 15, 2018

Requested changes have been fixed

@ntwb ntwb merged commit d336ddc into stylelint:master Jul 15, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.011%
Details
@ntwb

This comment has been minimized.

Member

ntwb commented Jul 15, 2018

Changelog updated in: 3455c64

Added: declaration-colon-space-before autofix (#3445).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment