New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundled support for styles in object literals #3506

Merged
merged 1 commit into from Aug 13, 2018

Conversation

3 participants
@gucong3000
Member

gucong3000 commented Jul 31, 2018

Which issue, if any, is this issue related to?

#3264

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

@gucong3000 gucong3000 force-pushed the postcss-jsx branch from ce64d03 to 7892cd2 Jul 31, 2018

@gucong3000 gucong3000 force-pushed the postcss-jsx branch from 7892cd2 to dfa22e2 Jul 31, 2018

@jeddy3

jeddy3 approved these changes Jul 31, 2018

LGTM, thanks!

@gucong3000 gucong3000 force-pushed the postcss-jsx branch from dfa22e2 to 42c1a24 Aug 1, 2018

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Aug 3, 2018

@gucong3000 Can you post some examples of what kind of styles this parser supports, please? So that I can create an accurate CHANGELOG entry.

@hudochenkov

Yeah, lint all the things!

Good work, @gucong3000!

Please, answer @jeddy3's question, so we can merge this PR.

@gucong3000

This comment has been minimized.

Member

gucong3000 commented Aug 13, 2018

Can you post some examples of what kind of styles this parser supports, please? So that I can create an accurate CHANGELOG entry.

I'm sorry to be late, I didn't online because of my grandma's funeral.

  • style component factories

      import glamorous from 'glamorous'; // choose any name for the defaut export
    
      const Component = glamorous.div({ ... });
      const OtherComponent = glamorous('div')({ ... })
  • JSX inline style attributes

      <Div style={{ ... }}/>
@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Aug 13, 2018

@gucong3000 sorry to hear this. My condolences.

@jeddy3 jeddy3 merged commit 1917eb9 into master Aug 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 96.029%
Details

@jeddy3 jeddy3 deleted the postcss-jsx branch Aug 13, 2018

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Aug 13, 2018

  • Added: bundled support for styles in CSS-in-JS object literals (#3506).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment