Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix false positives for selector-descendant-combinator-no-non-space #3508
This rule is a little bit strange in that a descendent combinator is always whitespace, it's just not always a single space. In fact the logic of the rule checks that the combinator is not one of the standard "non-space" combinators (+, >) and passes if that is the case.
For this particular bug, PostCSS apparently determined that
Anyway, since what are really looking is whitespace combinators that are not single spaces, I changed the logic to do that instead. It's a bit of a work-around but it covers the case in question and most importantly does not regress.
This might change in #3284.
LGTM. Even if the behaviour of the parser changes, I think the logic in this PR is clear.