Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to block-closing-brace-empty-line-before #3617

Conversation

boccob
Copy link
Contributor

@boccob boccob commented Aug 25, 2018

Which issue, if any, is this issue related to?

Closes #3614

Is there anything in the PR that needs further explanation?

ex.

  • option: always-multi-line

    code:

    a {
      color: pink;
    }

    fixed:

    a {
      color: pink;
    
    }
  • option: never

    code:

    a {
      color: pink;
    
    }

    fixed:

    a {
      color: pink;   
    }
  • option: ["never", { except: ["after-closing-brace"] }]

    code:

    @media print {
    
      a {
        color: aquamarine;
      }
    
      b {
        color: hotpink;
      }
    }

    fixed:

    @media print {
    
      a {
        color: aquamarine;
      }
    
      b {
        color: hotpink;
      }
    
    }
  • option: ["always-multi-line", { except: ["after-closing-brace"] }]

    code:

    @media print {
    
      a {
        color: aquamarine;
    
      }
    
      b {
        color: hotpink;
    
      }
    
    }

    fixed:

    @media print {
    
      a {
        color: aquamarine;
    
      }
    
      b {
        color: hotpink;
    
      }
    }

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boccob Thanks. LGTM.

@ota-meshi Are you able to cast a 2nd pair of eyes over this?

@jeddy3 jeddy3 merged commit b71af5c into stylelint:master Sep 6, 2018
@jeddy3
Copy link
Member

jeddy3 commented Sep 6, 2018

  • Added: block-closing-brace-empty-line-before autofix (#3598).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add autofix to block-closing-brace-empty-line-before
4 participants