New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to block-closing-brace-empty-line-before #3617

Merged
merged 1 commit into from Sep 6, 2018

Conversation

4 participants
@boccob
Contributor

boccob commented Aug 25, 2018

Which issue, if any, is this issue related to?

Closes #3614

Is there anything in the PR that needs further explanation?

ex.

  • option: always-multi-line

    code:

    a {
      color: pink;
    }

    fixed:

    a {
      color: pink;
    
    }
  • option: never

    code:

    a {
      color: pink;
    
    }

    fixed:

    a {
      color: pink;   
    }
  • option: ["never", { except: ["after-closing-brace"] }]

    code:

    @media print {
    
      a {
        color: aquamarine;
      }
    
      b {
        color: hotpink;
      }
    }

    fixed:

    @media print {
    
      a {
        color: aquamarine;
      }
    
      b {
        color: hotpink;
      }
    
    }
  • option: ["always-multi-line", { except: ["after-closing-brace"] }]

    code:

    @media print {
    
      a {
        color: aquamarine;
    
      }
    
      b {
        color: hotpink;
    
      }
    
    }

    fixed:

    @media print {
    
      a {
        color: aquamarine;
    
      }
    
      b {
        color: hotpink;
    
      }
    }
@jeddy3

jeddy3 approved these changes Sep 6, 2018

@boccob Thanks. LGTM.

@ota-meshi Are you able to cast a 2nd pair of eyes over this?

@ntwb

ntwb approved these changes Sep 6, 2018

@jeddy3 jeddy3 merged commit b71af5c into stylelint:master Sep 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.23%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Sep 6, 2018

  • Added: block-closing-brace-empty-line-before autofix (#3598).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment