New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 5 autofixes #3620 #3621

Merged
merged 2 commits into from Aug 29, 2018

Conversation

5 participants
@ota-meshi
Member

ota-meshi commented Aug 26, 2018

Which issue, if any, is this issue related to?

fixed #3620

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

@ntwb

ntwb approved these changes Aug 27, 2018

@@ -49,7 +49,7 @@ const rule = function(expectation, options, context) {
? ruleNode.raws.selector.raw
: ruleNode.selector;
commaIndices
.sort()
.sort((a, b) => a - b)

This comment has been minimized.

@boccob

boccob Aug 27, 2018

Contributor

Maybe .sort((a, b) => b - a) is a bit better than .sort((a, b) => a - b).reverse()

@ota-meshi

This comment has been minimized.

Member

ota-meshi commented Aug 27, 2018

@boccob
I changed sort.reverse to one sort.

@boccob

boccob approved these changes Aug 28, 2018

@jeddy3 jeddy3 merged commit 7e90d05 into master Aug 29, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.213%
Details

@jeddy3 jeddy3 deleted the fix/number-sort branch Aug 29, 2018

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Aug 29, 2018

  • Fixed: autofix for 5 whitespace rules (#3621).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment