Add autofix to function-max-empty-lines #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
requested changes
Sep 9, 2018
| @@ -53,6 +53,17 @@ const rule = function(max) { | |||
| index -= 1; | |||
| } | |||
|
|
|||
| if (context.fix) { | |||
| decl.value = ( | |||
There was a problem hiding this comment.
If value contains a comment, you must use decl.raws.value.raw.
| decl.toString().substring(0, index) + | ||
| decl.toString().substring(match.endIndex) | ||
| ) | ||
| .split(":")[1] |
There was a problem hiding this comment.
You can use declarationValueIndex.js to take the starting position.
There was a problem hiding this comment.
Can you add the following test case?
a { transform: /*c*/translate(\n\n\n1,1); }
|
Thank you for this PR. |
ota-meshi
reviewed
Sep 9, 2018
* add test to auto fix two places * use declarationValueIndex * add tests containing comments
|
Hi, thank you for reviewing my PR :) I have addressed the comments you left, let me know if there is something that should be improved! |
ota-meshi
reviewed
Sep 10, 2018
|
@Bilie Thank you for the great work :) |
ota-meshi
approved these changes
Sep 14, 2018
|
@Bilie LGTM! Thank you. |
ntwb
approved these changes
Sep 20, 2018
This was referenced Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3613
No, it's self explanatory