New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autofix for rule "selector-type-case" #3668

Merged
merged 1 commit into from Sep 24, 2018

Conversation

3 participants
@EliazTray
Member

EliazTray commented Sep 13, 2018

Which issue, if any, is this issue related to?

e.g. "Closes #3663 "

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

@EliazTray EliazTray closed this Sep 13, 2018

@EliazTray EliazTray reopened this Sep 13, 2018

@EliazTray

This comment has been minimized.

Member

EliazTray commented Sep 15, 2018

@ota-meshi

in branch master, it asls occurs this when run test. how to solve it?

@ota-meshi

This comment has been minimized.

Member

ota-meshi commented Sep 15, 2018

I think it is the same problem as here.

@ota-meshi

Thank you for this pull request!
I have a change request.

@ota-meshi

This comment has been minimized.

Member

ota-meshi commented Sep 20, 2018

@EliazTray

in branch master, it asls occurs this when run test. how to solve it?

It was solved!

@ota-meshi

This comment has been minimized.

Member

ota-meshi commented Sep 20, 2018

@EliazTray Thank you for excellent work!
but, I should have requested one more thing, but I overlooked it. sorry...

Could you add the following sentence to README.md?

The `--fix` option on the [command line](../../../docs/user-guide/cli.md#autofixing-errors) can automatically fix all of the problems reported by this rule.

Please refer to here.

@EliazTray EliazTray force-pushed the EliazTray:autofix/selector-type-case branch from ac6e2f7 to ec5536b Sep 21, 2018

@EliazTray

This comment has been minimized.

Member

EliazTray commented Sep 21, 2018

@ota-meshi
Thanks for your reviewing!
I had added the sentence and rebased the history commits.

@ota-meshi

LGTM! Thank you!

@jeddy3

jeddy3 approved these changes Sep 24, 2018

@EliazTray Thank you for your first-time contribution!

Sorry that it took a little while to get your PR merged. A lot of the team are busy with other things at the moment.

@jeddy3 jeddy3 merged commit 55a004e into stylelint:master Sep 24, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 96.404%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Sep 24, 2018

  • Added: selector-type-case autofix (#3668).

@EliazTray EliazTray deleted the EliazTray:autofix/selector-type-case branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment