Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for Less variables and mixins in at-rule-* #3767

Merged
merged 3 commits into from
Nov 1, 2018

Conversation

jwilsson
Copy link
Member

Which issue, if any, is this issue related to?

Closes #3764.

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

With this PR all at-rule-* rules should be ignoring Less mixins/variables.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@hudochenkov hudochenkov merged commit e9e73d5 into master Nov 1, 2018
@hudochenkov hudochenkov deleted the issue-3764 branch November 1, 2018 17:09
@hudochenkov
Copy link
Member

  • Fixed: at-rule-* false positives for Less variables and mixins (#3767).

@tgdev
Copy link

tgdev commented Nov 4, 2018

Hi there,

I'm using stylelint v9.7.1 in my project and a branch on my CI build is breaking due to lint errors that this PR seems to have fixed.

However, it seems like this PR was not published to npm as v.9.7.2 and I was wondering if these is an error or there's a reason for not publishing?

@jeddy3
Copy link
Member

jeddy3 commented Nov 6, 2018

If no one beats me to it, I should have time this evening to put out a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix false positives for Less variables and mixins in at-rule-semicolon-newline-after
5 participants