New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for Less variables and mixins in at-rule-* #3767

Merged
merged 3 commits into from Nov 1, 2018

Conversation

5 participants
@jwilsson
Member

jwilsson commented Oct 31, 2018

Which issue, if any, is this issue related to?

Closes #3764.

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

With this PR all at-rule-* rules should be ignoring Less mixins/variables.

@jeddy3

jeddy3 approved these changes Nov 1, 2018

Thanks! LGTM.

@evilebottnawi

Good work!

@hudochenkov hudochenkov merged commit e9e73d5 into master Nov 1, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 96.341%
Details

@hudochenkov hudochenkov deleted the issue-3764 branch Nov 1, 2018

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Nov 1, 2018

  • Fixed: at-rule-* false positives for Less variables and mixins (#3767).
@tgdev

This comment has been minimized.

tgdev commented Nov 4, 2018

Hi there,

I'm using stylelint v9.7.1 in my project and a branch on my CI build is breaking due to lint errors that this PR seems to have fixed.

However, it seems like this PR was not published to npm as v.9.7.2 and I was wondering if these is an error or there's a reason for not publishing?

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 6, 2018

If no one beats me to it, I should have time this evening to put out a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment