Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests to account for new syntax errors in PostCSS #3892

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Fix tests to account for new syntax errors in PostCSS #3892

merged 2 commits into from
Jan 16, 2019

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Jan 15, 2019 •
edited

Which issue, if any, is this issue related to?

Closes #3891

Is there anything in the PR that needs further explanation?

  1. Looking again at https://www.xanthir.com/b4U10, I think our tests and examples were wrong because I don't think you can have a space after the slashes.

  2. Remove an test of invalid CSS from value-list-comma-space-after

@jeddy3 jeddy3 mentioned this pull request Jan 15, 2019
Closed
@jeddy3 jeddy3 changed the title Fix usage of invalid double slashes Fix tests to account for new syntax errors in PostCSS Jan 15, 2019
hudochenkov
hudochenkov approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeddy3 jeddy3 merged commit e4e758d into master Jan 16, 2019
@jeddy3 jeddy3 deleted the fix-no-invalid-double branch January 16, 2019 09:36
@hudochenkov hudochenkov mentioned this pull request Jan 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@gucong3000 gucong3000 gucong3000 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An in-range update of postcss is breaking the build 🚨
3 participants
@jeddy3 @hudochenkov @gucong3000