Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negatives for `isStandardSyntaxDeclaration` #3933

Merged
merged 1 commit into from Apr 4, 2019

Conversation

4 participants
@gucong3000
Copy link
Member

commented Jan 30, 2019

Which issue, if any, is this issue related to?

Closes #3930

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@gucong3000 gucong3000 force-pushed the issues_3930 branch 5 times, most recently from 9ff574b to 43f695c Jan 30, 2019

@gucong3000 gucong3000 force-pushed the issues_3930 branch from 43f695c to d9f6d68 Jan 30, 2019

@hudochenkov
Copy link
Member

left a comment

Looks good! Thank you!

});
it("url with less interpolation at the end without quotes", () => {
expect(isStandardSyntaxUrl("some/@{less-variable}")).toBeTruthy();
expect(isStandardSyntaxUrl("some/@{less-variable}")).toBeFalsy();

This comment has been minimized.

Copy link
@evilebottnawi

evilebottnawi Apr 3, 2019

Member

Looks like a regression

This comment has been minimized.

Copy link
@hudochenkov

hudochenkov Apr 3, 2019

Member

Actually, it's a bug fix. Interpolation makes URL non-standard. There are tests for Sass interpolation and they all negative.

This comment has been minimized.

Copy link
@evilebottnawi

@jeddy3 jeddy3 merged commit 4ec7170 into master Apr 4, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 96.341%
Details

@jeddy3 jeddy3 deleted the issues_3930 branch Apr 4, 2019

@jeddy3

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

  • Fixed: false negatives in declaration-based rules for CSS-in-JS (#3933).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.