Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resolve-from to the latest version 馃殌 #4031

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Apr 15, 2019

The dependency resolve-from was updated from 4.0.0 to 5.0.0.

This version is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v5.0.0

Breaking:

  • Require Node.js 8 (#12) 188ed7d
  • Return undefined instead of null when the module cannot be found (#12) 188ed7d

Enhancements:

v4.0.0...v5.0.0

Commits

The new version differs by 2 commits.

  • 53f4a1b 5.0.0
  • 188ed7d Require Node.js 8, return undefined instead of null, add TypeScript definition (#12)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@ybiquitous
Copy link
Member

The resolve-from module is used in stylelint here: 猬囷笍

let path = resolveFrom.silent(basedir, lookup);
if (!path) {
path = resolveFrom.silent(process.cwd(), lookup);
}
if (!path) {
path = resolveFrom.silent(globalModules, lookup);
}
if (!path) {
throw configurationError(
`Could not find "${lookup}". Do you need a \`configBasedir\`?`
);
}

stylelint/lib/cli.js

Lines 420 to 423 in f77b140

optionsBase.configFile =
resolveFrom.silent(process.cwd(), cli.flags.config) ||
path.join(process.cwd(), cli.flags.config);
}

@ybiquitous
Copy link
Member

The resolve-from@5.0.0 major update has a breaking change that the silent function's return type changes from null to undefined, which it doesn't seem to affect stylelint's behavior.

https://github.com/sindresorhus/resolve-from/blob/53f4a1b40f972dbfc4dda9627d24068000eae897/index.js#L35-L41

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@ntwb ntwb merged commit e6b0e15 into master Apr 15, 2019
@greenkeeper greenkeeper bot deleted the greenkeeper/resolve-from-5.0.0 branch April 15, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants