Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass needlessDisables to formatter #4137

Closed
wants to merge 1 commit into from
Closed

Pass needlessDisables to formatter #4137

wants to merge 1 commit into from

Conversation

shawnbot
Copy link
Contributor

This is intended to allow custom formatters to output information about needless disables.

Which issue, if any, is this issue related to?

Fixes #4136.

Is there anything in the PR that needs further explanation?

Probably, but let me see if I can get this working first. 馃槵

TODO

  • Make it work
  • Add specific tests and update relevant, existing ones
  • Update docs

@shawnbot
pass needlessDisables to formatting function
d9035ee 
This allows custom formatters to output information about needless disables.
@shawnbot
Copy link
Contributor Author

I'm going to revive this in a new PR from a fresher fork.

@shawnbot shawnbot closed this Oct 31, 2019
@shawnbot shawnbot deleted the patch-1 branch October 31, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix custom formatters access to needless disables results
2 participants
@shawnbot @hudochenkov