Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no-eol-whitespace #4224

Merged
merged 3 commits into from
Aug 30, 2019
Merged

fix no-eol-whitespace #4224

merged 3 commits into from
Aug 30, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Aug 23, 2019

Which issue, if any, is this issue related to?

fix #4218 #3842

Is there anything in the PR that needs further explanation?

nothing

vankop
vankop commented Aug 23, 2019
View reviewed changes
lib/rules/no-eol-whitespace/__tests__/index.js
},
{
message: messages.rejected,
line: 1,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evilebottnawi looks like we don't support CR =(

@vankop vankop closed this Aug 23, 2019
@vankop vankop reopened this Aug 23, 2019
@vankop
Copy link
Member Author

vankop commented Aug 23, 2019 •
edited

tests work locally on OSX, will try to restart one more time

@vankop vankop closed this Aug 23, 2019
@vankop vankop reopened this Aug 23, 2019
@hudochenkov
Copy link
Member

@vankop do you have rights both in Travis and AppVeyor to restart? If not, tell me where do you not have an access. Closing and re-opening produces unnecessary email spam.

hudochenkov
hudochenkov approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vankop
Copy link
Member Author

vankop commented Aug 30, 2019 •
edited

@hudochenkov did not find where restart button in AppVeyor, in Travis I have rights

Sorry for spam

@hudochenkov
Copy link
Member

When you go to build https://ci.appveyor.com/project/stylelint/stylelint/builds/26918044. You have to be signed with Github and have stylelint selected. You should see “Re-build PR” button.

Screenshot 2019-08-30 at 12 41 14

@hudochenkov hudochenkov merged commit b433df3 into stylelint:master Aug 30, 2019
@hudochenkov
Copy link
Member

  • Fixed: no-eol-whitespace autofix for within comments (#4224).
  • Fixed: no-eol-whitespace false negatives for last line without trailing EOL (#4224).

@vankop vankop deleted the fix-eol-whitespace branch August 30, 2019 11:11
@vankop
Copy link
Member Author

vankop commented Aug 30, 2019

@hudochenkov I don't have access =(
Снимок экрана 2019-08-30 в 14 26 21

@hudochenkov
Copy link
Member

@vankop I made some changes in AppVeyor. Could you check again, please?

@vankop
Copy link
Member Author

vankop commented Aug 30, 2019

I made some changes in AppVeyor. Could you check again, please?

Thanks, now it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false negatives for last line without trailing EOL in no-eol-whitespace
3 participants
@vankop @hudochenkov @alexander-akait