Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten ESLint rules. #4462

Merged
merged 7 commits into from
Dec 29, 2019
Merged

Tighten ESLint rules. #4462

merged 7 commits into from
Dec 29, 2019

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Nov 30, 2019 •
edited

I open this for discussion. Most of these rules, if not all, should be made to the upstream eslint config.

Notes:

  • I haven't enabled some of the rules on purpose
  • prefer-rest-params needs further changes but IMHO it's totally worth it
  • prefer-spread same as above, but we need to test if everything will still work with Node.js 8.7.0; we might need >= 8.10.0

@ntwb
Copy link
Member

ntwb commented Nov 30, 2019

...if everything will still work with Node.js 8.7.0; we might need >= 8.10.0

Node.JS v8 is end-of-life in ~31 days on 2019-12-31

Happy to plan for this by ignoring that and dropping Node.js support in the next major release

@XhmikosR XhmikosR force-pushed the master-xmr-eslint branch 3 times, most recently from 19da514 to 64bb726 Compare November 30, 2019 11:35
@XhmikosR
Copy link
Member Author

Will the next version be a major version one? Regardless, if tests pass on Node.js 8.7.0 (ATM we test the latest 8.x not the minimum supported one), I guess we should be OK.

After we decide on the rules, I will make an upstream PR. IMHO we should also move parserOptions to the upstream config.

@XhmikosR XhmikosR force-pushed the master-xmr-eslint branch 2 times, most recently from ef0a848 to 37dd452 Compare December 2, 2019 08:22
@XhmikosR
Copy link
Member Author

I rebased this. There are still a few errors to fix (any help is welcome) and after we agree on the rules then we can move the newly added rules to our eslint config.

IMHO most of these changes are good, but this stuff is always objective :)

PS. tests seems to pass on Node.js 8.7.0 so we should be covered regarding 8.x compatibility.

hudochenkov
hudochenkov reviewed Dec 28, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of rules make sense and enforce good practices.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@XhmikosR
Copy link
Member Author

@hudochenkov if you merge this please don't squash your patches with mine. Feel to squash your patches into one if you prefer, but being you made significant changes, authorship should be preserved.

@hudochenkov
Copy link
Member

I'm afraid all changes will be squashed into one commit, where I will be Co-Author. We don't have any other methods of merge enabled for this repository.

@hudochenkov hudochenkov marked this pull request as ready for review December 28, 2019 13:44
@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 28, 2019 •
edited

I believe a rebase and merge is possible and if not, it should be made possible by changing the repository's settings.

I don't want to show as the author of changes I didn't make myself. Even if the coauthor line is added, it doesn't show who did what.

XhmikosR
XhmikosR commented Dec 28, 2019
View reviewed changes
lib/utils/typeGuards.js
@@ -39,6 +39,6 @@ module.exports.isComment = function isComment(node) {
* @param {Node} node
* @returns {node is (Node & {source: NodeSource})}
*/
module.exports.hasSource = function isComment(node) {
return !!node.source;
module.exports.hasSource = function hasSource(node) {
Copy link
Member Author

@XhmikosR XhmikosR Dec 28, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove the function name here; not sure what's used more in the codebase. This change just ensures consistency.

@XhmikosR
Copy link
Member Author

@hudochenkov I have two more rules I forgot to add, but shouldn't need a lot of changes. Can I push them here?

@hudochenkov
Copy link
Member

Sure, but don't force push :)

@XhmikosR XhmikosR mentioned this pull request Dec 29, 2019
Closed
@XhmikosR
Copy link
Member Author

Alright, I'm done with the rule changes. I have an issue opened in eslint-config-stylelint to backport the new rules.

@hudochenkov hudochenkov merged commit 1dfaee8 into master Dec 29, 2019
@hudochenkov hudochenkov deleted the master-xmr-eslint branch December 29, 2019 11:54
@hudochenkov hudochenkov mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @ntwb @hudochenkov