Minor lint tweaks #4693
Merged
Minor lint tweaks #4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
master-xmr-lint
branch
2 times, most recently
from
1ee0c78
to
47da955
Compare
* simplify regex * use Unicode escape in regex * use `trimStart()` instead of the `trimLeft()` alias * remove unneeded path separator from imports
|
@XhmikosR Is this a draft or ready for review? |
|
I forgot I had it as draft. It's ready. |
hudochenkov
approved these changes
May 6, 2020
@hudochenkov ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trimStart()instead of thetrimLeft()aliasI split these from the
xobranch, let me know if you want me to make any changes 馃檪PS. I didn't change the
0-9to\din regex for now since I wasn't sure if everyone would like this change.