Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for release #4779

Merged
merged 4 commits into from
May 16, 2020
Merged

Update dependencies for release #4779

merged 4 commits into from
May 16, 2020

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented May 16, 2020

Which issue, if any, is this issue related to?

It's preparation for release (#4746).

Is there anything in the PR that needs further explanation?

Only the isMultiple breaking change in meow needed addressing.

Other dependencies with major releases, but no changes required for us:

@jeddy3 jeddy3 mentioned this pull request May 16, 2020
Closed
6 tasks
ybiquitous
ybiquitous reviewed May 16, 2020
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's enough to merge, but I suggest some improvements.

package.json Show resolved Hide resolved
lib/cli.js Show resolved Hide resolved
@jeddy3
Copy link
Member Author

jeddy3 commented May 16, 2020

@ybiquitous Thanks. Good catches. Changes made.

m-allanson
m-allanson approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ybiquitous
ybiquitous approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeddy3 Thanks, LGTM 👍

@jeddy3 jeddy3 merged commit f4043ae into master May 16, 2020
@jeddy3 jeddy3 deleted the update-release-deps branch May 16, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-allanson m-allanson m-allanson approved these changes

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeddy3 @m-allanson @ybiquitous