Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new 'prepareReturnValue' module #4832

Merged
merged 1 commit into from Jun 20, 2020

Conversation

m-allanson
Copy link
Member

In a future PR this module will be required by the new browser.js module. This change has been extracted from: #4796.

Which issue, if any, is this issue related to?

Related to issue #3935

Is there anything in the PR that needs further explanation?

This change is a small part of the changes in PR #4796

In a future PR this module will be required by the new `browser.js` module. This change has been extracted from: #4796
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@m-allanson m-allanson mentioned this pull request Jun 17, 2020
14 tasks
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m-allanson
Copy link
Member Author

Thanks for all the reviews :)

@m-allanson m-allanson merged commit e110b4c into master Jun 20, 2020
@m-allanson m-allanson deleted the issue-3935/refactor-prepare-return-value branch June 20, 2020 11:01
m-allanson added a commit that referenced this pull request Jun 20, 2020
# By jeddy3 (4) and others
# Via GitHub
* master:
  Create new 'prepareReturnValue' module (#4832)
  13.6.1
  Scope eslint disable
  Prepare 13.6.1
  Update deps
  Update CHANGELOG.md
  Fix false positives for idents within ::part pseudo-elements in selector-type-no-unknown (#4828)
  Bump np from 6.2.3 to 6.2.4 (#4830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants