Add support for a TAP formatter #5062
Conversation
| @@ -91,7 +91,14 @@ declare module 'stylelint' { | |||
| returnValue?: StylelintStandaloneReturnValue, | |||
| ) => string; | |||
|
|
|||
| export type FormatterIdentifier = 'compact' | 'json' | 'string' | 'unix' | 'verbose' | Formatter; | |||
| export type FormatterIdentifier = | |||
There was a problem hiding this comment.
Added tap as an option but format was adjusted by prettier
Signed-off-by: John Cline <2057878+clinejj@users.noreply.github.com>
|
Changelog entry:
|
| ); | ||
| }); | ||
|
|
||
| lines.push('---'); |
There was a problem hiding this comment.
According to https://testanything.org/tap-version-14-specification.html#yaml-diagnostics it should be ..., right?
There was a problem hiding this comment.
We have implemented the version 13, not version 14:
But it seems v13 also requires an ending ..., according to https://testanything.org/tap-version-13-specification.html:
If the test line is immediately followed by an indented block beginning with
/^\s+---/and ending with/^\s+.../that block will be interpreted as an inline YAML document.
So, it makes sense for me to fix --- to .... Additionally, we might be able to update the TAP version from 13 to 14.
Can you create an issue or pull request if you have time?
There was a problem hiding this comment.
I was reviewing which formatter would have the fixed mention.
see #4664 (comment)
Can you create an issue or pull request if you have time?
Not right away no, but what I wonder is why it wasn't picked up for all these years.
The tap consumers must be very lax.
This is weird.
update the TAP version from 13 to 14
👍
This PR adds support for a TAP formatter using an update to the code snippet from @danielsamuels discussed in #3889.
Closes #3889
No, it is self explanatory. Used #3524 as a starting point.