Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix named-grid-area-no-invalid README #5187

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Fix named-grid-area-no-invalid README #5187

merged 2 commits into from
Mar 8, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Mar 6, 2021

Which issue, if any, is this issue related to?

None, as it's a documentation fix.

Is there anything in the PR that needs further explanation?

The invalid patterns aren't given a red background on the website. We should have used the "expanded description" instead.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

lib/rules/named-grid-areas-no-invalid/README.md Outdated Show resolved Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3 jeddy3 merged commit d9dddf2 into master Mar 8, 2021
@jeddy3 jeddy3 deleted the fix-docs branch March 8, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants