Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selector-disallowed-list rule #5239

Conversation

@doing-art
Copy link
Contributor

@doing-art doing-art commented Apr 11, 2021

Which issue, if any, is this issue related to?

Closes #5116 .

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@doing-art doing-art changed the title Feature/5116 add selector disallowed list rule Add selector-disallowed-list rule Apr 11, 2021
@doing-art
Copy link
Contributor Author

@doing-art doing-art commented Apr 11, 2021

Hello everyone.

One check related to this PR fails. Should I fix it? Or it is an infrastructural issue and you will fix it on your own?

Loading

@hudochenkov
Copy link
Member

@hudochenkov hudochenkov commented Apr 11, 2021

@doing-art It was a weird issue. Tests restart helped.

Loading

@doing-art
Copy link
Contributor Author

@doing-art doing-art commented Apr 11, 2021

@doing-art It was a weird issue. Tests restart helped.

Thanks a lot for your help. I really appreciate it

Loading

Copy link
Member

@ybiquitous ybiquitous left a comment

@doing-art Thanks for the contribution! LGTM for the code changed. 👍

I've left some comments for the document, so please confirm them.

Loading

docs/user-guide/rules/list.md Outdated Show resolved Hide resolved
Loading
lib/rules/selector-disallowed-list/README.md Outdated Show resolved Hide resolved
Loading
lib/rules/selector-disallowed-list/README.md Outdated Show resolved Hide resolved
Loading
lib/rules/selector-disallowed-list/README.md Outdated Show resolved Hide resolved
Loading
doing-art and others added 4 commits Apr 12, 2021
Added a dot symbol to the `selector-disallowed-list` rule

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Added a dot symbol to the `selector-disallowed-list` rule

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Add detailed description of the paramteres of `selector-disallowed-list` rule

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Copy link
Member

@ybiquitous ybiquitous left a comment

@doing-art Thank you for addressing my suggestions!
I've left a trivial suggestion, but your change looks good to me! 😄

Loading

lib/rules/selector-disallowed-list/README.md Outdated Show resolved Hide resolved
Loading
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
jeddy3
jeddy3 approved these changes Apr 20, 2021
Copy link
Member

@jeddy3 jeddy3 left a comment

Thank you, LGTM.

Loading

@jeddy3 jeddy3 merged commit 2e72f65 into stylelint:master Apr 20, 2021
13 checks passed
Loading
@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Apr 20, 2021

Changelog entry added:

  • Added: selector-disallowed-list rule (#5239).

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants