Fix custom property sets #5307
Merged
Fix custom property sets #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudochenkov
approved these changes
May 15, 2021
jeddy3
added a commit
that referenced
this pull request
May 20, 2021
jeddy3
added a commit
that referenced
this pull request
Jun 7, 2021
* Update postcss dependencies * Fix invalid position for attribute selector (#5305) * Fix custom property sets (#5307) * Update dependencies * Fix types issues after PostCSS update (#5346) * Migrate stylelint PostCSS plugin to Visitors API (#5353) Co-authored-by: Aleks Hudochenkov <aleks@hudochenkov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5304
PostCSS used to parse custom property sets as
rulenodes, and we added code to some of our built-in rules to handle this. PostCSS now parsers them asdeclnodes:{ "prop": "--foo", "value": "{ color: red; }" }The spec is abandoned and we should no longer attempt to support it.
This pull request remove any special handling of custom property sets.
It fixes 4 more tests. Leaving only the disable-ranges one.