Refactor to remove some uses of _.get and _.set
#5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
reviewed
May 28, 2021
There was a problem hiding this comment.
@stephenwade Thank you for making this change! 👏🏼
Could you check my review comments, please?
jeddy3
changed the title
_.get and _.set_.get and _.set
|
Hi @ybiquitous, I've implemented your suggested changes. |
ybiquitous
approved these changes
May 28, 2021
| disabledRanges: {}, | ||
| ruleSeverities: {}, | ||
| customMessages: {}, | ||
| }; |
There was a problem hiding this comment.
[note] I'm a bit concerned about the newly added properties like disabledRanges, but it seems due to our TypeScript definitions (maybe another issue). 🤔
Anyway, I think no problems going on as-is. 👍🏼
There was a problem hiding this comment.
Yes, that was because of the TypeScript definitions. It wouldn't let me just set result.stylelint to {}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4412.
Most of the code is self-explanatory. I replaced the simpler uses of
_.getand_.setwith native code.I had to change a couple of
array.forEachloops to regularfor … of arrayloops to maketschappy. I also updated the JSDoc types in a couple places for the same reason.