Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Dependabot on default branch #5452

Merged
merged 1 commit into from Aug 11, 2021

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

See #5439

Is there anything in the PR that needs further explanation?

Currently, we have mainly developed on the v14 branch.

See also:
https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#open-pull-requests-limit

Note: This PR's base branch should be master.

@ybiquitous ybiquitous added the pr: dependencies relates to dependencies label Aug 11, 2021
@ybiquitous
Copy link
Member Author

ybiquitous commented Aug 11, 2021

@jeddy3
Copy link
Member

jeddy3 commented Aug 11, 2021

I think the CI got overwhelmed. Let's merge this anyway.

I've cancelled and deleted all the other pending dependabot runs. There was a dozen or so languishing.

@ybiquitous ybiquitous merged commit c2a0036 into master Aug 11, 2021
@ybiquitous ybiquitous deleted the disable-dependabot-on-default-branch branch August 11, 2021 23:37
@ybiquitous
Copy link
Member Author

Sorry for the inconvenience... 🙇🏼

ybiquitous added a commit that referenced this pull request Aug 11, 2021
This change is a retry of PR #5439 and also a revert of PR #5452.
Maybe, `target-branch: v14` should be set on the `master` branch, not `v14`.
jeddy3 pushed a commit that referenced this pull request Aug 12, 2021
This change is a retry of PR #5439 and also a revert of PR #5452.
Maybe, `target-branch: v14` should be set on the `master` branch, not `v14`.
@jeddy3
Copy link
Member

jeddy3 commented Aug 12, 2021

Sorry for the inconvenience... 🙇🏼

No worries at all! Updating all the dependencies is a job that needed doing as we'd fallen quite far behind, and by getting dependabot sorted on the v14 branch we can ensure we stay up to date.

ybiquitous added a commit that referenced this pull request Sep 2, 2021
* Disable Dependabot on default branch (#5452)

Currently, we have mainly developed on the `v14` branch. See #5439.

See also:
https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#open-pull-requests-limit

* Set `target-branch: v14` for Dependabot again (#5453)

This change is a retry of PR #5439 and also a revert of PR #5452.
Maybe, `target-branch: v14` should be set on the `master` branch, not `v14`.

* Fix max-empty-lines before comments

* Update snapshot

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: dependencies relates to dependencies
Development

Successfully merging this pull request may close these issues.

None yet

3 participants