Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky cache test via jest.retryTimes() #5533

Merged
merged 2 commits into from Sep 14, 2021
Merged

Fix flaky cache test via jest.retryTimes() #5533

merged 2 commits into from Sep 14, 2021

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Close #5531

Is there anything in the PR that needs further explanation?

See the Jest doc.

@@ -38,6 +38,9 @@ function getConfig(additional = {}) {
}

describe('standalone cache', () => {
// NOTE: The test may fail depending on the timing of the access to the cache file. See #5531
jest.retryTimes(3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dirty hack 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I cannot find a way to handle access to expectedCacheFilePath properly... 😅

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

It'll avoid us having fails on unrelated pull requests.

@jeddy3 jeddy3 merged commit dbfd171 into v14 Sep 14, 2021
@jeddy3 jeddy3 deleted the issue-5531 branch September 14, 2021 15:50
@jeddy3 jeddy3 mentioned this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants