Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extends in overrides config #5603

Merged
merged 1 commit into from Oct 19, 2021
Merged

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

None, but related to #3128.

Is there anything in the PR that needs further explanation?

This PR adds support for extends in overrides config.

e.g.

{
  "overrides": [
    {
      "files": ["*.scss"],
      "extends": "stylelint-config-recommended-scss"
    }
  ]
}

This option allows users to use config by language.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we need to update the document about the overrides property?

E.g.

https://github.com/stylelint/stylelint/blob/bf2802506ff04d59c5e352c86de99552449859ac/docs/user-guide/configure.md#overrides

@ota-meshi
Copy link
Member Author

I don't think we need to update the document.
If we don't merge this PR and don't support extends, I think we need to add it to document as an unsupported property.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. LGTM 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants