Add ignore: ["rules"] / ["at-rules"] to block-opening-brace-*-after #5262 #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
requested changes
Jan 14, 2022
There was a problem hiding this comment.
Thanks for the pull request. It looks good.
I've requested some changes to the docs and tests (as committable suggestions).
(This is likely to be one of the last pull requests we accept for stylistic rules (see #5830). That's not to say that these rules can't be migrated to a community maintained plugin, and continued to be worked on. After #5830 is merged, I'll make time to close all the related issues.)
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
ybiquitous
reviewed
Jan 14, 2022
There was a problem hiding this comment.
@Crocsx Thank you for creating the pull request!
I've left some suggestions to fix the lint and test errors.
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
Thanks sorry about that |
jeddy3
approved these changes
Jan 17, 2022
|
Changelog entry added:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this is what requested for this :
Close #5262