Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for revert and revert-layer in font-family-no-missing-generic-family-keyword #5852

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Fix false positives for revert and revert-layer in font-family-no-missing-generic-family-keyword #5852

merged 2 commits into from
Jan 20, 2022

Conversation

treemmett
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #5850

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

ybiquitous
ybiquitous approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treemmett Thank you! LGTM 👍🏼

@jeddy3 jeddy3 changed the title revert and revert-layer keywords Fix false positives for revert and revert-layer in font-family-no-missing-generic-family-keyword Jan 20, 2022
jeddy3
jeddy3 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeddy3 jeddy3 merged commit 5ca792f into stylelint:main Jan 20, 2022
@jeddy3
Copy link
Member

jeddy3 commented Jan 20, 2022

Changelog entry added:

  • Fixed: font-family-no-missing-generic-family-keyword false positives for revert and revert-layer (#5852).

@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for revert and revert-layer in font-family-no-missing-generic-family-keyword
3 participants
@treemmett @jeddy3 @ybiquitous