Refactor to replace style-search for functionArgumentsSearch()
#5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing `style-search` with `postcss-value-parser`.
ybiquitous
commented
Feb 6, 2022
| @@ -3,10 +3,17 @@ | |||
| const functionArgumentsSearch = require('../functionArgumentsSearch'); | |||
|
|
|||
| it('passes function arguments to callback', () => { | |||
| expect.assertions(2); | |||
There was a problem hiding this comment.
[note] Added expect.assertions() to ensure assertions executed in the callback.
| @@ -63,7 +63,7 @@ const rule = (primary) => { | |||
|
|
|||
| functionArgumentsSearch( | |||
| valueParser.stringify(valueNode).toLowerCase(), | |||
| 'linear-gradient', | |||
| /^(-webkit-|-moz-|-o-)?linear-gradient$/i, | |||
There was a problem hiding this comment.
[note] postcss-value-parser doesn't seem to support the fuzzy match. Instead, using regex.
ybiquitous
commented
Feb 6, 2022
|
|
||
| it('passes function arguments to callback when a case with mutiple expressions', () => { | ||
| expect.assertions(2); | ||
|
|
There was a problem hiding this comment.
[note] Splitted into smaller test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5499
(I think this PR is the last one of #5499)
Replacing
style-searchwithpostcss-value-parser.