Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add declaration-property-max-values #5920

Merged
merged 13 commits into from
Mar 7, 2022
Merged

Add declaration-property-max-values #5920

merged 13 commits into from
Mar 7, 2022

Commits on Feb 18, 2022

  1. drafts declaration-property-max-values

    @mattxwang
    mattxwang committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    206da50 View commit details
    Browse the repository at this point in the history

  2. adds extra test case for irrelevant property, removes redundant code

    @mattxwang
    mattxwang committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    bf017ea View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    9b6634a View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. slims down docs/test cases to use valid CSS, div -> a, all value nodes 

    Applies suggestions from code review:

- removes invalid CSS from docs and test cases
- removes redundant docs entries
- uses `a` for all selectors
- writes a new helper "isValueNode" to cover word, function, string value types
- adds new test case for css variable
    @mattxwang
    mattxwang committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    f94fc00 View commit details
    Browse the repository at this point in the history

  2. creates validateObjectWithProps, validates options for declaration-pr… 

    …operty-max-values
    @mattxwang
    mattxwang committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    62ba6c1 View commit details
    Browse the repository at this point in the history

  3. adds tests for validateObjectWithProps

    @mattxwang
    mattxwang committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    1d2d400 View commit details
    Browse the repository at this point in the history

  4. adds additional test case for invalid input to validateObjectWithProps

    @mattxwang
    mattxwang committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    7955ad1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into declaration-property-max-values

    @mattxwang
    mattxwang committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2430b2a View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review - typo fixes and validator typing 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    03ddbf8 View commit details
    Browse the repository at this point in the history

  7. removes unused template type

    @mattxwang
    mattxwang committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    57c4f4e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Apply suggestions from code review 

    Moves `validateOptions` outside of `walkDecls`, better type annotation style!

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    c5889cd View commit details
    Browse the repository at this point in the history

  2. Update lib/rules/declaration-property-max-values/index.js 

    Moves external require to top of require list

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @mattxwang @jeddy3
    mattxwang and jeddy3 committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    6a5d57b View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. swaps border, margin configuration properties to re-add margin-inline

    @mattxwang
    mattxwang committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    1d0efd9 View commit details
    Browse the repository at this point in the history