Fix end positions for no-duplicate-*
#6047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsure of what the highlighted positions should be / what's the most useful for the VSCode extension. Right now, it just highlights the first duplicate selector. I believe this is because of the implementation of the `word` parsing. Is it more useful to highlight each duplicate selector? The last one? etc.
Two concerns: - not sure if calling `atRule.toString()` is the appropriate use; should I be using `raws`? - in this case, my suggested start/end positions are larger than the message rejection, but it aims to match the positions indicated in the README
mattxwang
commented
Apr 29, 2022
| @@ -81,8 +85,10 @@ testRule({ | |||
| warnings: [ | |||
| { | |||
| message: messages.rejected('a', 1), | |||
| line: 1, | |||
| line: 2, | |||
There was a problem hiding this comment.
I believe this line was previously incorrect; both a selectors are on lines 2 and 3 respectively, so I'm not sure how 1 would be reported.
If that is true, what does this mean for the test process? Is it because we didn't report a start index either?
mattxwang
changed the title
no-duplicate-*no-duplicate-*
3 tasks
ybiquitous
approved these changes
May 9, 2022
There was a problem hiding this comment.
@mattxwang Thank you. Your implementation has no problems 👍🏼
Maybe, we could improve end positions for no-duplicate-selectors (see #6075), but this pull request is enough for now.
|
Changelog entry added:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the umbrella issue #5694.
I have a couple of questions on how to implement the end positions for these two rules, mostly due to my lack of experience. Would like some opinions!
For
no-duplicate-at-import-rules:@import ...). I've currently opted for the latter, since it seems more useful for editor support.atRule.toString()correct? I feel a bit strange writing this. Should I be recreating it withrawsinstead?For
no-duplicate-selectors:Once these are clarified, I can add
endLineandendColumnto each of the test cases for standard CSS syntax.