Publicly expose reference data #6152
Conversation
|
Note: this shouldn't be merged until people have a chance to discuss #6151 |
There was a problem hiding this comment.
@nex3 Thanks for creating the pull request!
I think there are no significant problems. Could you consider addressing my review comments? Of course, you can do it after the discussion.
| @@ -364,6 +364,77 @@ declare module 'stylelint' { | |||
| line?: number; | |||
| }; | |||
|
|
|||
| export type KeywordSets = { | |||
There was a problem hiding this comment.
[suggest] Could you add a type annotation to each module like this? By doing so, we could improve the code's type safety.
// lib/reference/keywordSets.js
/** @type {import('stylelint').KeywordSets} */
const keywordSets = {};
// ...
module.exports = (keywordSets);| ## 14.10.0 | ||
|
|
||
| - Added: `reference` export, which contains reference data from the CSS spec that may be useful for custom lints. | ||
|
|
There was a problem hiding this comment.
[suggest] Could you revert the change, please? We will update the changelog after merged.
| ## 14.10.0 | |
| - Added: `reference` export, which contains reference data from the CSS spec that may be useful for custom lints. |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "stylelint", | |||
| "version": "14.9.1", | |||
| "version": "14.10.0", | |||
There was a problem hiding this comment.
[suggest] Could you revert the version, please? It will be automatically updated on release.
| "version": "14.10.0", | |
| "version": "14.9.1", |
|
I'm going to close this out in favor of #6168, which is a more principled approach to the same goal. |
Closes #6151