Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for multiple match in declaration-property-value-allowed-list #6190

Merged
merged 1 commit into from Jun 30, 2022
Merged

Fix false positives for multiple match in declaration-property-value-allowed-list #6190

merged 1 commit into from Jun 30, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6187

Is there anything in the PR that needs further explanation?

This fix is similar to #6188.

See also #6187 (comment)

@ybiquitous ybiquitous marked this pull request as ready for review June 30, 2022 13:16
jeddy3
jeddy3 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ybiquitous ybiquitous merged commit 9054636 into main Jun 30, 2022
@ybiquitous ybiquitous deleted the fix-false-positives-in-declaration-property-value-allowed-list branch June 30, 2022 13:26
@ybiquitous
Copy link
Member Author

@jeddy3 Thanks for the quick review! Changelog entry added:

  • Fixed: declaration-property-value-allowed-list false positives for multiple match (#6190).

@sync-by-unito sync-by-unito bot mentioned this pull request Sep 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false negatives for multiple matches in *-list
2 participants
@ybiquitous @jeddy3