Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump jest from 28.1.3 to 29.0.2, jest-preset-stylelint from 5.0.4 to 6.0.0 #6332

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Bump jest from 28.1.3 to 29.0.2, jest-preset-stylelint from 5.0.4 to 6.0.0 #6332

merged 5 commits into from
Oct 24, 2022

Conversation

mattxwang
Copy link
Member

@mattxwang mattxwang commented Sep 7, 2022 •
edited
Loading

Which issue, if any, is this issue related to?

Supersedes #6321.

Is there anything in the PR that needs further explanation?

CI currently fails due to this change in jest-preset-stylelint, version 6:

  • Removed: support for Node.js less than 14.15.0.

Not sure how we want to handle merging this, etc. - can also just close this PR if we'd like to wait!

Related to - #6311

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 03ee9b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mattxwang mattxwang added the pr: dependencies relates to dependencies label Sep 7, 2022
@jeddy3
Copy link
Member

jeddy3 commented Sep 9, 2022

Not sure how we want to handle merging this, etc. - can also just close this PR if we'd like to wait!

We can keep it open. I'll label as blocked by #6311.

@jeddy3 jeddy3 added the pr: blocked is blocked by another issue or pr label Sep 9, 2022
@ybiquitous ybiquitous mentioned this pull request Sep 12, 2022
Closed
@ybiquitous ybiquitous mentioned this pull request Oct 24, 2022
Closed
@dependabot
Bump eslint from 8.25.0 to 8.26.0 (#6422)
142e477 
Bumps [eslint](https://github.com/eslint/eslint) from 8.25.0 to 8.26.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.25.0...v8.26.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ybiquitous ybiquitous mentioned this pull request Oct 24, 2022
Closed
@ybiquitous
Copy link
Member

The v15 branch is now available as a destination to push this commit. So we can go forward with this PR.

@mattxwang mattxwang marked this pull request as ready for review October 24, 2022 01:51
@mattxwang mattxwang marked this pull request as draft October 24, 2022 01:52
@mattxwang mattxwang changed the base branch from main to v15 October 24, 2022 03:31
@jeddy3
Copy link
Member

jeddy3 commented Oct 24, 2022

It looks like it's just the snapshots that need updating:

npm run jest -- -u

Because of this breaking change in 29.0.0:

[jest-config] [BREAKING] Make snapshotFormat default to escapeString: false and printBasicPrototype: false (jestjs/jest#13036)

@jeddy3 jeddy3 removed the pr: blocked is blocked by another issue or pr label Oct 24, 2022
@mattxwang
Update snapshots with npm run jest -- -u
03ee9b3 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

Thanks @jeddy3
@mattxwang
Copy link
Member Author

Thanks @jeddy3! (think I mangled the co-authored commit message, but I can add it when I merge)

@jeddy3 jeddy3 marked this pull request as ready for review October 24, 2022 19:06
jeddy3
jeddy3 approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@mattxwang mattxwang merged commit 8192fe4 into v15 Oct 24, 2022
@mattxwang mattxwang deleted the mattxwang/bump-jest-and-preset branch October 24, 2022 23:49
@mattxwang
Copy link
Member Author

I've been a bit behind on contributing - @ybiquitous did you want me to also edit CHANGELOG, or does the Changesets automation do that for us now?

@ybiquitous
Copy link
Member

@mattxwang I'm not sure, but probably the Changeset GitHub App doesn't work on branches except for main. We can run npx changeset add locally to add a changelog entry instead.

@jeddy3
Copy link
Member

jeddy3 commented Oct 25, 2022

did you want me to also edit CHANGELOG

Let's not add an entry for this pull request as it's not a user-facing change.

ybiquitous pushed a commit that referenced this pull request Nov 8, 2022
@mattxwang @jeddy3 @ybiquitous
Bump jest from 28.1.3 to 29.0.2, jest-preset-stylelint from 5.0.4 to …
4fa526d 
…6.0.0 (#6332)

* Bump jest from 28.1.3 to 29.0.2, jest-preset-stylelint from 5.0.4 to 6.0.0

* Bump eslint from 8.25.0 to 8.26.0 (#6422)

Bumps [eslint](https://github.com/eslint/eslint) from 8.25.0 to 8.26.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.25.0...v8.26.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

* Update snapshots with `npm run jest -- -u`

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
pr: dependencies relates to dependencies
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattxwang @jeddy3 @ybiquitous