New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document list of rules by what-they-do groups #6390
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeddy3 Thank you for the significant improvements! 👏🏼
I've left comments to suggest fixing trivial mistakes, but any comments don't block this PR. Please feel free to address or reject them.
lib/rules/font-family-no-missing-generic-family-keyword/README.md
Outdated
Show resolved
Hide resolved
Note: Perhaps, we may need to update stylelint/lib/rules/alpha-value-notation/index.js Lines 21 to 22 in 6599729
- url: 'https://stylelint.io/user-guide/rules/list/alpha-value-notation',
+ url: 'https://stylelint.io/user-guide/rules/alpha-value-notation', But then, because redirecting also will be added, it seems we can do it after publishing the new documents. |
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@ybiquitous Thanks for all the suggestions.
Done also. The URL is nicer without Prepped the stylelint.io repo: stylelint/stylelint.io#285 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM 👍🏼
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Ref: #6376 (comment)
This pull request groups our list of rules by what they do rather than what they're applied to.
I believe this approach helps our users more easily:
You can view the page here.
I think it does a better job of communicating the number of powerful rules we have for enforcing non-stylistic conventions that are unique to Stylelint.
This change also surfaced a lot of inconsistencies in our rule descriptions, which I've fixed in this pull request.
Grouping by the thing the rule applies to was mostly redundant as the rule name starts with it. I've still used those sub groups for the larger
no-*
and*-list
group for readability, though. And I kept the old system for the stylistic rules as they'll be removed at some point.The list of rules page now leads with just enough information for users to understand what they're looking at, i.e.:
I've moved other information that lived on the "About rules" page to the "Working on rules" page in the developer guide, which feel like a better home for it as it's more useful for people writing rules than using them.