Add no-unknown-custom-properties rule
#6731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa21969 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jameschensmith
changed the title
no-unknown-custom-propertiesno-unknown-custom-properties rule
jameschensmith
force-pushed
the
rules/no-unknown-custom-properties
branch
from
7db1033
to
ff1d4f8
Compare
ybiquitous
reviewed
Mar 27, 2023
There was a problem hiding this comment.
@jameschensmith Thanks for the pull request! The code and doc look good to me, though I just left a trivial suggestion.
jameschensmith
force-pushed
the
rules/no-unknown-custom-properties
branch
from
ff1d4f8
to
fa21969
Compare
ybiquitous
approved these changes
Mar 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds new rule,
no-unknown-custom-properties, which disallows unknown custom properties. Initial implementation is to consider custom properties defined within the same source.Relates to #6361. Could close the issue if a new one is created to track a potential
importFromoption, or aresolveroption once #4088 is addressed.