Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media-feature-range-notation parse error #6760

Conversation

fpetrakov
Copy link
Contributor

Closes #6754

Is there anything in the PR that needs further explanation?

No, it's self-explanatory

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: e2333a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change @fpetrakov 🙇
One thought but the change looks good!

lib/utils/parseMediaQuery.js Show resolved Hide resolved
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, thank you so much for this 🙇

I am not yet fully up to speed with all the conventions and best practices, so maybe @ybiquitous can best take another look?

@ybiquitous ybiquitous changed the title Fix media-feature-range-notation parse error Fix media-feature-range-notation parse error Apr 4, 2023
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. LGTM 👍🏼

@ybiquitous ybiquitous merged commit 4a8662e into stylelint:main Apr 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix media-feature-range-notation parse error
3 participants