Fix declaration-block-no-redundant-longhand-properties autofix for grid-template
#6777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba5b2ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattxwang
force-pushed
the
fix-decl-block-no-redun-lghnd-props-grid-template
branch
from
fbdfc03
to
1e68516
Compare
mattxwang
force-pushed
the
fix-decl-block-no-redun-lghnd-props-grid-template
branch
from
1e68516
to
0321073
Compare
|
After thinking on it a bit more, I'm not sure what the other alternative is to resolve this problem (other than a "custom resolver" methodology). Going to mark this as ready to review, but I'm anticipating that it'll need some changes! |
ybiquitous
requested changes
Apr 20, 2023
There was a problem hiding this comment.
@mattxwang Thanks for the pull request. I've commented on a few refactoring ideas, so can you check them?
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
…ndex.js Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
Thanks for the suggestions! I think I've incorporated all of them (in a slightly-messy git history 😅 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6701.
A handful of thoughts:
gridshorthand, since the situation there is quite a bit more complicated with theauto-flowsyntax element (spec ref)More broadly, I'm happy to own any other changes that need to be made to this autofixer.