Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media-feature-name-no-unknown false positive for not and or #6838

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented May 9, 2023

Which issue, if any, is this issue related to?

Closes #6834

Is there anything in the PR that needs further explanation?

This update will remove support for any custom syntax in media queries.

Before this change this rule would attempt to parse less, scss, ... and give warnings on unknown feature names, even when the feature value was non-standard syntax.

This is not possible with the other parser.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

🦋 Changeset detected

Latest commit: 8935e23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mattxwang mattxwang mentioned this pull request May 15, 2023
4 tasks
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, and sorry for the late review! I have a question.

lib/rules/media-feature-name-no-unknown/index.js Outdated Show resolved Hide resolved
lib/rules/media-feature-name-no-unknown/index.js Outdated Show resolved Hide resolved
romainmenke and others added 7 commits May 15, 2023 16:24
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
…itives-on-types-and-modifiers--compassionate-insect-50ef6d6325
…ypes-and-modifiers--compassionate-insect-50ef6d6325' of https://github.com/stylelint/stylelint into fix-media-feature-name-no-unknown--false-positives-on-types-and-modifiers--compassionate-insect-50ef6d6325
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! LGTM 👍🏼

@romainmenke romainmenke merged commit 838ffe8 into main May 16, 2023
14 checks passed
@romainmenke romainmenke deleted the fix-media-feature-name-no-unknown--false-positives-on-types-and-modifiers--compassionate-insect-50ef6d6325 branch May 16, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix media-feature-name-no-unknown false positives for not keyword
2 participants