-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string
formatter for unexpected truncation on non-ASCII characters
#6861
Conversation
🦋 Changeset detectedLatest commit: 7a01eae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This may be the same problem as gajus/table#180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. There seem to be no big problems. 👍🏼
Please consider addressing my refactoring suggestions.
stringFormatter
unexpected truncation on non-ascii charactersstring
formatter for unexpected truncation on non-ascii characters
string
formatter for unexpected truncation on non-ascii charactersstring
formatter for unexpected truncation on non-ASCII characters
OK, thanks for your review,i will refactor it soon~ |
…aracter class escape` & cache `getMessageWidth` result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM 👍🏼
See issus: stringFormatter.js truncate non-ASCII characters unexpectedly
Closes #6860
The reason that why don't I just contribute code to repository
table
, is: make it to support full ability about non-ASCII seems like a lot of work. before it, we can solve the problem in this way first。