New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix color-*
performance
#6868
Fix color-*
performance
#6868
Conversation
🦋 Changeset detectedLatest commit: d0f8541 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
What about having a |
…-elephant-740c875825
|
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
…rmance--adaptable-asian-elephant-740c875825
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ask]
- Can you add a changelog entry?
- Will this PR close Fix performance of constructor parsing rules #6869?
No, I've added a todo list to that issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 👍🏼
Thank you for reviewing all this @ybiquitous and @Mouvedia 🙇 |
See:
color-*
rulescolor-*
rulesI don't mind splitting this up into multiple PR's, one for each rule, but the changes are all similar and minor.
I am unsure what the preference is in this project for balancing the extra noise and review work of multiple PR's vs. the clarity of small chunks. I didn't want to open ±10 PR's without prior discussion :)