Refactor to remove unneeded isLessVariable() utility
#6995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No grep match: ```console $ git grep 'isLessVariable' || echo '(no match)' (no match) ``` Also, this change adds a tiny script to find unused module files: ```console $ node scripts/find-unused-modules.mjs lib/utils/isStandardSyntaxMathFunction.js lib/utils/isStandardSyntaxMediaFeature.js ``` I will address other unused files later.
ybiquitous
force-pushed
the
remove-unneeded-isLessVariable
branch
from
beadaa8
to
6099ef6
Compare
|
Okay, I'll do it. 👍🏼 |
mattxwang
pushed a commit
that referenced
this pull request
Jun 29, 2023
No grep match: ```console $ git grep 'isLessVariable' || echo '(no match)' (no match) ``` Also, this change adds a tiny script to find unused module files: ```console $ node scripts/find-unused-modules.mjs lib/utils/isStandardSyntaxMathFunction.js lib/utils/isStandardSyntaxMediaFeature.js ``` I will address other unused files later.
ybiquitous
added a commit
that referenced
this pull request
Nov 13, 2023
This script file was added in #6995. We don't need it anymore since unused modules were resolved.
ybiquitous
added a commit
that referenced
this pull request
Nov 13, 2023
Remove unused `scripts/find-unused-modules.mjs` This script file was added in #6995. We don't need it anymore since unused modules were resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None.
No grep match:
Also, this change adds a tiny script to find unused module files:
I will address other unused files
laterwith follow-up PRs.Note: See also #6971 (comment)
I tried the ESLint rule
import/no-unused-modules, but it didn't work expectedly. Please help if anyone knows. If the rule works, it's preferred over the custom script.