Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor replaceBackslashes() test utility to migrate to ESM #7034

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Refactor replaceBackslashes() test utility to migrate to ESM #7034

merged 1 commit into from
Jul 3, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Ref #5291

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2023

⚠️ No Changeset found

Latest commit: 2de3171

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jeddy3
jeddy3 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@ybiquitous ybiquitous marked this pull request as ready for review July 3, 2023 11:36
@ybiquitous
Copy link
Member Author

Thanks for the quick review!

@ybiquitous ybiquitous merged commit 74c90b3 into main Jul 3, 2023
18 checks passed
@ybiquitous ybiquitous deleted the esm-replaceBackslashes branch July 3, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3