New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an ability to pass a function for severity secondary option #7202
Conversation
🦋 Changeset detectedLatest commit: d8d7bb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
78da116
to
09f373c
Compare
09f373c
to
8c30e1b
Compare
@ybiquitous Sure, rebased to v16. Is there an ETA for when the v16 is expected to be released? |
@kizu Thank you. I'm sorry, but no ETA for now. If possible, I hope to release v16 this year, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big problems, thank you so much.
I've left some minor suggestions, so I'd appreciate your addressing them. 🙏🏼
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kizu Thanks for addressing my reviews. LGTM! 👍🏼
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Let me know if I should add more tests (if so, where?), or change something in the docs.
I did implement the feature as described in the #6863 (comment) comment.
Closes #6863
No, it's self-explanatory.