Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to pass a function for severity secondary option #7202

Merged
merged 2 commits into from Oct 3, 2023

Conversation

kizu
Copy link
Member

@kizu kizu commented Sep 29, 2023

Let me know if I should add more tests (if so, where?), or change something in the docs.

I did implement the feature as described in the #6863 (comment) comment.

Which issue, if any, is this issue related to?

Closes #6863

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

🦋 Changeset detected

Latest commit: d8d7bb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ybiquitous
Copy link
Member

@kizu Thanks for creating this PR! I'm so afraid, but could you recreate this PR on the v16 branch? Since we have already pushed many commits into the v16 branch, we had to address conflicts if a big change would be merged into the main branch. 🙏🏼

@kizu kizu changed the base branch from main to v16 October 2, 2023 11:29
@kizu
Copy link
Member Author

kizu commented Oct 2, 2023

@ybiquitous Sure, rebased to v16. Is there an ETA for when the v16 is expected to be released?

@ybiquitous
Copy link
Member

@kizu Thank you. I'm sorry, but no ETA for now. If possible, I hope to release v16 this year, though.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big problems, thank you so much.
I've left some minor suggestions, so I'd appreciate your addressing them. 🙏🏼

docs/user-guide/configure.md Outdated Show resolved Hide resolved
docs/user-guide/configure.md Outdated Show resolved Hide resolved
docs/user-guide/configure.md Outdated Show resolved Hide resolved
.changeset/functional-severity.md Outdated Show resolved Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@kizu kizu requested a review from ybiquitous October 2, 2023 14:05
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kizu Thanks for addressing my reviews. LGTM! 👍🏼

@ybiquitous ybiquitous merged commit 8e66566 into stylelint:v16 Oct 3, 2023
13 of 14 checks passed
@kizu kizu deleted the functional-severity branch October 3, 2023 16:10
ybiquitous added a commit that referenced this pull request Oct 19, 2023
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add severity secondary option's function support
3 participants