Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreRules to max-nesting-depth #7215

Merged
merged 3 commits into from Oct 7, 2023

Conversation

mattxwang
Copy link
Member

@mattxwang mattxwang commented Oct 7, 2023

Which issue, if any, is this issue related to?

Closes #6529 (and thus, closes #2696 and closes #4805).

Is there anything in the PR that needs further explanation?

  1. I've add co-author annotations to credit @sjarva and @ybiquitous with their contributions in the original PR; we should keep these when/if we merge. Also happy to merge this back into Add ignoreRules to max-nesting-depthrule #6529 if @sjarva would like; I think we should give her the authorship for this commit if possible.
  2. I noticed that there's a possibility where if both ignoreRules and ignorePseudoClasses are used together (as siblings), the original PR does not properly treat that combination as fully ignored. I've added a test case to verify that and then fix it in cfa98ab. The code isn't very elegant, so suggestions are welcome!

mattxwang and others added 3 commits October 6, 2023 17:46
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Senja Jarva <senja@jarva.fi>
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2023

🦋 Changeset detected

Latest commit: 258bb54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍🏼

@mattxwang mattxwang merged commit e468814 into main Oct 7, 2023
18 checks passed
@mattxwang mattxwang deleted the add-ignore-selectors-to-max-nesting-depth branch October 7, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ignoreSelectors: [] to max-nesting-depth Add ignoreRules: [] to max-nesting-depth
3 participants