New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix declaration-block-no-redundant-longhand-properties
autofix for grid-template
with repeat()
#7230
Conversation
…`grid-template` with `repeat()`
🦋 Changeset detectedLatest commit: 8902506 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lib/rules/declaration-block-no-redundant-longhand-properties/__tests__/index.mjs
Show resolved
Hide resolved
As part of an existing package dependency or as an internal util? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattxwang Thanks for the pull request. This is almost good to me. 👍🏼
Are we interested in making a
repeat
parser?
Such a parser may be present, but I think this PR's simple string check is enough for now (the parser seems over-engineering to me for now).
lib/rules/declaration-block-no-redundant-longhand-properties/__tests__/index.mjs
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
…ndex.js Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 👍🏼
FYI. Note this is not required. Maybe Line 138 in f1d3228
cc @romainmenke |
Closes #7228.
Added the test case from the issue + the swapped version with
rows
instead ofcolumns
.Are we interested in making a
repeat
parser? I could add it to my personal backlog (though this would probably be after the ESM migration, etc.). I'm also not sure what existing tooling is here (maybe there's some existing csstools/postcss/other parser that we can use)?