Fix no longer needed workaround for Cosmiconfig segfault #7329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 634842b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Maybe related to nodejs/node#35889. The patch was released in Node.js 20. |
jeddy3
reviewed
Nov 13, 2023
|
Yes. $ node -v
v18.18.2
$ bin/stylelint.mjs --config scripts/visual-config.cjs scripts/*.css
scripts/visual.css
1:1 ✖ Unknown rule unit-case unit-case
1:1 ✖ Unknown rule string-quotes string-quotes
1:9 ✖ Expected "url("foo.css")" to be ""foo.css"" import-notation
4:9 ✖ Unexpected invalid hex color "#4f" color-no-invalid-hex
6:1 ✖ Expected ".foo.bar" to have no more than 1 class selector-max-class
7:10 ✖ Unexpected unit "px" unit-disallowed-list
8:3 ⚠ Expected custom property name to be kebab-case custom-property-pattern
7 problems (6 errors, 1 warning) |
4 tasks
This was referenced Nov 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7322
This workaround was introduced in #6902. See also #6898.
Note: This PR skips a few cases that failed due to segfault. See the source comment for details.