Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-pseudo-class-no-unknown false positives for :seeking, the media loading state and sound state pseudo-classes #7490

Merged
merged 1 commit into from Jan 22, 2024

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Jan 22, 2024

Which issue, if any, is this issue related to?

Closes #7477

Is there anything in the PR that needs further explanation?

I am planning a followup PR for the missing media pseudo-elements.
see #5959 (comment)

Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: 8fe123b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. Overall sounds good! 👍🏼

Can you fix the changelog item's prefix? Ref:

- prefix the entry with either: "Removed", "Changed", "Deprecated", "Added", "Fixed" or "Security"

.changeset/friendly-poems-taste.md Outdated Show resolved Hide resolved
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@jeddy3 jeddy3 changed the title Fix selector-pseudo-class-no-unknown resource state false positives Fix selector-pseudo-class-no-unknown false positives for resource state Jan 22, 2024
- :seeking
- :buffering
- :stalled
- :muted
- :volume-locked
@jeddy3 jeddy3 changed the title Fix selector-pseudo-class-no-unknown false positives for resource state Fix selector-pseudo-class-no-unknown false positives for :seeking, the media loading state and sound state pseudo-classes Jan 22, 2024
@ybiquitous ybiquitous merged commit a889974 into stylelint:main Jan 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix selector-pseudo-class-no-unknown false positives for all resource state pseudo-classes
3 participants